-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve prediction input descriptions #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lint task is failing. How do I lint? Edit: |
fofr
reviewed
Aug 29, 2024
fofr
reviewed
Aug 29, 2024
fofr
reviewed
Aug 29, 2024
fofr
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some suggested changes, hopefully addressing some of the nuance there is with flux
Co-authored-by: fofr <[email protected]>
Co-authored-by: fofr <[email protected]>
Co-authored-by: fofr <[email protected]>
Thanks for the improvements @fofr 💚 |
What's our workflow for getting changes like this pushed to the Replicate model(s)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more details and recommendations to the prediction input descriptions.
Summary:
Improved input parameter descriptions in
predict.py
for better guidance and consistency.Key points:
predict.py
for clearer guidance.prompt
description to includetrigger_word
usage.num_inference_steps
for detailed image generation.guidance_scale
explanation for value effects.seed
andoutput_format
for consistency.Generated with ❤️ by ellipsis.dev