Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve prediction input descriptions #20

Merged
merged 8 commits into from
Aug 30, 2024

Conversation

zeke
Copy link
Member

@zeke zeke commented Aug 28, 2024

This PR adds more details and recommendations to the prediction input descriptions.


🚀 This description was created by Ellipsis for commit 4184fa2

Summary:

Improved input parameter descriptions in predict.py for better guidance and consistency.

Key points:

  • Enhanced input descriptions in predict.py for clearer guidance.
  • Updated prompt description to include trigger_word usage.
  • Clarified num_inference_steps for detailed image generation.
  • Improved guidance_scale explanation for value effects.
  • Added periods to seed and output_format for consistency.

Generated with ❤️ by ellipsis.dev

@zeke
Copy link
Member Author

zeke commented Aug 28, 2024

Lint task is failing. How do I lint?

Edit: ruff format

predict.py Outdated Show resolved Hide resolved
predict.py Outdated Show resolved Hide resolved
predict.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@fofr fofr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some suggested changes, hopefully addressing some of the nuance there is with flux

zeke and others added 3 commits August 29, 2024 12:48
@zeke
Copy link
Member Author

zeke commented Aug 29, 2024

Thanks for the improvements @fofr 💚

@zeke zeke requested a review from fofr August 29, 2024 19:49
@andreasjansson andreasjansson merged commit 2b3297b into main Aug 30, 2024
2 checks passed
@andreasjansson andreasjansson deleted the improve-prediction-input-descriptions branch August 30, 2024 12:32
@zeke
Copy link
Member Author

zeke commented Aug 30, 2024

What's our workflow for getting changes like this pushed to the Replicate model(s)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants