Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pydantic2 cog builds #2115

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Fix pydantic2 cog builds #2115

merged 4 commits into from
Jan 21, 2025

Conversation

8W9aG
Copy link
Contributor

@8W9aG 8W9aG commented Jan 17, 2025 •
edited
Loading

  • Add an integration test to validate the problem
  • Upgrade fastapi to >= 0.100 to support pydantic 2

@8W9aG 8W9aG mentioned this pull request Jan 17, 2025
Closed
nickstenning
nickstenning approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@nickstenning nickstenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@8W9aG 8W9aG merged commit b7aa7c3 into main Jan 21, 2025
21 checks passed
@8W9aG 8W9aG deleted the sackfield/fix-pydantic2-cog branch January 21, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickstenning nickstenning nickstenning approved these changes

@meatballhat meatballhat Awaiting requested review from meatballhat

@nevillelyh nevillelyh Awaiting requested review from nevillelyh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8W9aG @nickstenning