Add serve command #2040
Merged
Add serve command #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to run the HTTP server command very similar to what is used in Replicate production. By making this command more within reach, my hope is that more Cog users will build familiarity with and opinions about the HTTP server interface. Connected to PLAT-259
erbridge
approved these changes
Nov 7, 2024
nickstenning
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
I like it!
Let's run this past @bfirsh and/or @superhighfives as a quick reasonableness check? Otherwise LGTM.
|
Agreed that this makes sense—I think my only request would be to add the details to the |
Co-authored-by: F <[email protected]> Signed-off-by: Dan Buch <[email protected]>
|
Love it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to run an HTTP server command very similar to what is used in Replicate production. By making this command more within reach, my hope is that not only is it easier and more clear to run Cog in its HTTP server mode, but also that more Cog users will build familiarity with and opinions about the HTTP server interface.
Connected to PLAT-259