Fix possible data corruption due to race condition in StreamRedirector #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yen-Nan (Maso) Lin <[email protected]> Signed-off-by: Maso Lin <[email protected]>
Signed-off-by: Maso Lin <[email protected]>
Signed-off-by: Maso Lin <[email protected]>
| with self._events_lock: | ||
| if isinstance(result, types.GeneratorType): | ||
| self._events.send(PredictionOutputType(multi=True)) | ||
| for r in result: |
There was a problem hiding this comment.
This is holding the lock for wayyyyyy too long. If the result is generator we absolutely should not be holding the lock for the entire for r in result loop.
I wonder if this is related to the occasional customer report of not getting logs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1758
Resolves #982 Resolves #1308 Resolves #1446