Implement pre-build repository check for Replicate images #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Etelis
force-pushed
the
1678-check-model-before-build
branch
from
0b81fcb to
c591912
Compare
mattt
reviewed
Jun 11, 2024
mattt
reviewed
Jun 11, 2024
mattt
reviewed
Jun 11, 2024
|
@mattt Any other notes on this? |
- Added `ManifestInspect` function in `pkg/docker` to use `docker manifest inspect` for verifying if an image exists on a registry. - Updated `push` function in `pkg/cli/push.go` to call `ManifestInspect` before building, specifically for Replicate images. - Ensured early feedback if the model does not exist on Replicate, preventing unnecessary build time and resources. Signed-off-by: Itay Etelis <[email protected]>
Signed-off-by: Itay Etelis <[email protected]>
Signed-off-by: Mattt <[email protected]>
mattt
force-pushed
the
1678-check-model-before-build
branch
from
94a6a56 to
bc4e9bb
Compare
|
@Etelis Thanks again for your work on this PR! I just applied one last suggestion from code review and rebased. Once CI passes, I'll get this merged in. |
mattt
approved these changes
Jun 22, 2024
|
Wow thanks @Etelis! @allcontributors please add @Etelis for code |
|
I've put up a pull request to add @Etelis! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManifestInspectfunction inpkg/dockerto verify if a Docker image exists on a registry using thedocker manifest inspectcommand.pushfunction inpkg/cli/push.goto include a check for the existence of a model on the Replicate registry before initiating the build process.References: