Add passing test that includes Torch and TensorFlow together #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mattt Zmuda <[email protected]>
mattt
force-pushed
the
mattt/torch-and-tensorflow-test
branch
from
c62dd43 to
1fcb983
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #710
#1023 created a failing test case where Cog dropped TensorFlow from requirements when specified in combination with PyTorch. This PR provides a passing test case to show a combination of package versions that does work.
The underlying issue of #710 is that this fails silently, and this PR doesn't address that. I just wanted to put this out there in case this unblocks anyone in this situation.