Display log output for predict

This still needs cleaning up. #169 Closes #137 Closes #154 Signed-off-by: Ben Firshman <[email protected]>
replicate · Jul 30, 2021 · f451eea · f451eea
1 parent f557cda
commit f451eea
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/pkg/cli/predict.go b/pkg/cli/predict.go
@@ -101,7 +101,7 @@ func cmdPredict(cmd *cobra.Command, args []string) error {
 		Image:   image,
 		Volumes: volumes,
 	})
-	if err := predictor.Start(); err != nil {
+	if err := predictor.Start(os.Stderr); err != nil {
 		return err
 	}
 

diff --git a/pkg/docker/logs.go b/pkg/docker/logs.go
@@ -0,0 +1,14 @@
+package docker
+
+import (
+	"io"
+	"os"
+	"os/exec"
+)
+
+func ContainerLogsFollow(containerID string, out io.Writer) error {
+	cmd := exec.Command("docker", "container", "logs", "--follow", containerID)
+	cmd.Env = os.Environ()
+	cmd.Stdout = out
+	return cmd.Run()
+}
diff --git a/pkg/predict/predictor.go b/pkg/predict/predictor.go
@@ -32,7 +32,7 @@ func NewPredictor(runOptions docker.RunOptions) Predictor {
 	return Predictor{runOptions: runOptions}
 }
 
-func (p *Predictor) Start() error {
+func (p *Predictor) Start(logsWriter io.Writer) error {
 	var err error
 	p.port, err = shell.NextFreePort(5000 + rand.Intn(1000))
 	if err != nil {
@@ -49,6 +49,11 @@ func (p *Predictor) Start() error {
 	if err != nil {
 		return fmt.Errorf("Failed to start container: %w", err)
 	}
+	go func() {
+		if err := docker.ContainerLogsFollow(p.containerID, logsWriter); err != nil {
+			console.Warnf("Error getting container logs: %s", err)
+		}
+	}()
 
 	return p.waitForContainerReady()
 }