Add helper to Properties class +cleanups #469
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asolntsev
requested changes
Oct 26, 2024
|
Good point will look at it. |
|
@asolntsev I've looked into it. I've subclassed Properties (the class of Play.configuration) to ConfigurationProperties and tried to use that instead of Properties: this is quite an invasive change. Properties (the one from java.util) is passed around quite a bit and that then should all become ConfigurationProperties. I think the resulting PR will look a lot worse than the one I suggested. Also: there's a Properties implementation in RePlay as well, but that is seemingly unused. |
Sorry, I didn't understand why is this an invasive change? |
|
@asolntsev I've update the branch. |
|
@asolntsev wrote:
Good point. I've updated the branch accordingly. |
asolntsev
reviewed
Jan 22, 2025
cies
changed the title
|
I dont know why the Locally this ( Two completely different test failures, that do not occur consistently over the different contexts (local CLI and remote Github CI)... I think all is fine, but somehow things got flaky. |
asolntsev
approved these changes
Feb 11, 2025
| } | ||
|
|
||
| /** Helper method of an often recurring type of check on Play's configuration properties. */ | ||
| public PropertyResult property(final String key, final String defaultValue) { |
There was a problem hiding this comment.
@cies I would name this class PropertyValue, not PropertyResult.
It seems that the word "result" doesn't bring any value, like "PropertyObject" or "PropertyClass".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were doing the same thing in many places.
I added a helper method. I can also think of another way to implement this: subclass
PropertiestoPlayPropertiesand add the helper method there.@xabolcs Sorry for adding some IntelliJ spelling fixes into this PR. I'm very much in the habit of scanning every file I touch for minor cleanup work.