Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add converge implementation #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erdivartanovich
Copy link

Hi, I've tried to implements FP interface in go, but then I saw that you have achieve more implementations here.
So I decide to use this package instead. But I think I need something close to Ramda Converge.
So maybe this could be added here

Add Converge implementation

@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (7cc0526) compared to base (7f1a9fe).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        13    +1     
  Lines          369       371    +2     
=========================================
+ Hits           369       371    +2     
Impacted Files Coverage Δ
converge.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@repeale
Copy link
Owner

repeale commented Sep 26, 2022

Hey @erdivartanovich thanks for contributing.
I'm wondering if:
1 - there is not a way to keep the same signature, keeping the array. If you tried which challenges did you faced
2 - if there is a different way to achieve the same result. Thinking about splitting the problem in two, applying a value to a series of functions and running a function over the results.
Happy if you are going to use the lib!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants