Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand more views for modal open function #3691

Merged
merged 9 commits into from
Jan 21, 2025
Merged

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Jan 20, 2025

Description

Expanded more views in the modal open function to include Swap, Send, Wallet Is a Wallet, Wallet Is a Network and All Wallets.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1873

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 0:05am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 0:05am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-vue-solana ⬜️ Ignored (Inspect) Jan 21, 2025 0:05am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jan 21, 2025 0:05am
vue-wagmi-example ⬜️ Ignored (Inspect) Jan 21, 2025 0:05am

Copy link

linear bot commented Jan 20, 2025

Copy link

changeset-bot bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: d89b296

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit Patch
@reown/appkit-core Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 68.58% 19530 / 28475
🔵 Statements 68.58% 19530 / 28475
🔵 Functions 59.36% 1705 / 2872
🔵 Branches 79.83% 3448 / 4319
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client.ts 62.26% 84.44% 76.88% 62.26% 177-178, 207-208, 223-224, 227-228, 243-246, 249-252, 272-273, 276-277, 293-314, 317-326, 595-596, 599-602, 605-606, 609-610, 613-614, 617-618, 625-629, 692-695, 722-723, 737-738, 747-748, 751-752, 757-758, 775-776, 797-799, 826-837, 840-877, 880-885, 901-905, 918-929, 932-951, 954-960, 963-973, 976-988, 991-993, 996-998, 1001-1003, 1006-1008, 1011-1018, 1023-1081, 1085-1104, 1112-1126, 1129-1136, 1139-1153, 1156-1162, 1167, 1171, 1185, 1198-1199, 1207, 1210-1213, 1216-1222, 1232-1233, 1262-1278, 1291-1294, 1298, 1314-1324, 1333-1334, 1339, 1345-1363, 1369-1376, 1387-1395, 1413-1423, 1426-1506, 1509-1529, 1548, 1560, 1569-1570, 1576, 1578, 1591, 1632, 1665-1676, 1679-1687, 1716-1732, 1747-1751, 1783-1787, 1808-1809, 1814-1815, 1817-1818, 1823-1826, 1877-1881, 1906-1907, 1931-1932, 1961-1962, 1966-1967, 2037-2053, 2059-2066, 2079, 2081-2083, 307-318, 2050-2051
Generated in workflow #9073 for commit d89b296 by the Vitest Coverage Report Action

@tomiir tomiir merged commit 4075214 into main Jan 21, 2025
11 of 13 checks passed
@tomiir tomiir deleted the feat/open-more-views branch January 21, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants