refactor: handle undefined caipNetwork when calling syncBalance #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fe56fc5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
enesozturk
force-pushed
the
refactor/handle-syncbalance-for-unsupported-networks-and-cleanup-appkit-client-tests
branch
from
7ab04e9 to
879d0e7
Compare
svenvoskamp
approved these changes
Jan 17, 2025
tomiir
reviewed
Jan 17, 2025
Comment on lines
+21
to
+23
| ? isNaN(Number(stringChainId)) | ||
| ? stringChainId | ||
| : Number(stringChainId) |
There was a problem hiding this comment.
why do this instead of return?
There was a problem hiding this comment.
When we parse caipNetworkId, for both EVM and other chains the chainId will be string, but it's EVM only when Number(stringChainId)
This is to return correct typed chainId instead just string for it.
Previously we've been returning '1' for Mainnet, not it'll return 1
zoruka
approved these changes
Jan 17, 2025
…networks-and-cleanup-appkit-client-tests
…networks-and-cleanup-appkit-client-tests
enesozturk
deleted the
refactor/handle-syncbalance-for-unsupported-networks-and-cleanup-appkit-client-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
syncBalanceType of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist