fix: cloudauth siwx address match #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 38570a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tomiir
requested review from
zoruka,
enesozturk,
Cali93,
svenvoskamp and
magiziz
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
tomiir
changed the title
magiziz
reviewed
Jan 16, 2025
| @@ -72,7 +72,10 @@ export class CloudAuthSIWX implements SIWXConfig { | |||
|
|
|||
| const siweCaipNetworkId = `eip155:${siweSession?.chainId}` | |||
|
|
|||
| if (!siweSession || siweCaipNetworkId !== chainId || siweSession.address !== address) { | |||
| const isSameAddress = siweSession?.address.toLowerCase() === address.toLowerCase() | |||
There was a problem hiding this comment.
Can we use HelpersUtil.isLowerCaseMatch ?
magiziz
approved these changes
Jan 16, 2025
enesozturk
reviewed
Jan 16, 2025
| @@ -72,7 +72,10 @@ export class CloudAuthSIWX implements SIWXConfig { | |||
|
|
|||
| const siweCaipNetworkId = `eip155:${siweSession?.chainId}` | |||
There was a problem hiding this comment.
@tomiir I remember we've been checking this code piece together and refactored xd Not sure if it's broken later or we introduced an issue
enesozturk
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where a non-cased address response from a wallet would cause 1CA to fail on CloudAuthSIWX
Type of change
Checklist