Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prettier sort plugin #3649

Merged
merged 8 commits into from
Jan 15, 2025
Merged

chore: prettier sort plugin #3649

merged 8 commits into from
Jan 15, 2025

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Jan 15, 2025

Description

Introduces import sorting plugin to the repo. Trivago's sort plugin allow us to separate the imports into groups as we configure with regexes.

The current implementation separates them as:

  1. React deps (for example apps and laboratory which is one of our main apps)
  2. Third party modules
  3. Lit (our main module which we use in our UI comps and views)
  4. Reown libraries (monorepo modules)
  5. Absolute paths (we are using on some apps like Demo or example Next.js apps)
  6. Relative paths

Resources

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

Before After
current formatted

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: 7dc5ae2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 2:36pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 2:36pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-vue-solana ⬜️ Ignored (Inspect) Jan 15, 2025 2:36pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jan 15, 2025 2:36pm
vue-wagmi-example ⬜️ Ignored (Inspect) Jan 15, 2025 2:36pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants