Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flag SOLANA_PRIVATE_KEY and EIP155_PRIVATE_KEY as optional #3624

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Jan 13, 2025

Description

Removes EIP155_PRIVATE_KEY and SOLANA_PRIVATE_KEY from required inputs in ui_tests.yml

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@tomiir tomiir requested review from zoruka and magiziz January 13, 2025 18:39
Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: b2ce080

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 6:43pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 6:43pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-vue-solana ⬜️ Ignored (Inspect) Jan 13, 2025 6:43pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jan 13, 2025 6:43pm
vue-wagmi-example ⬜️ Ignored (Inspect) Jan 13, 2025 6:43pm

Copy link
Contributor

Warnings
⚠️

Workflow file .github/workflows/ui_tests.yml has been modified

Generated by 🚫 dangerJS against b2ce080

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 64.7% 18323 / 28316
🔵 Statements 64.7% 18323 / 28316
🔵 Functions 55.37% 1581 / 2855
🔵 Branches 78.31% 3016 / 3851
File CoverageNo changed files found.
Generated in workflow #8779 for commit b2ce080 by the Vitest Coverage Report Action

@tomiir tomiir merged commit c7c99b0 into main Jan 13, 2025
19 checks passed
@tomiir tomiir deleted the fix/remove-required-secrets branch January 13, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants