feat: default account type option #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e22eb34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zoruka
force-pushed
the
feat/default-account-type-option
branch
from
a55f3cd to
284b907
Compare
tomiir
reviewed
Jan 10, 2025
…efault-account-type-option
zoruka
force-pushed
the
feat/default-account-type-option
branch
from
9a1b6e0 to
c6cab6a
Compare
enesozturk
reviewed
Jan 14, 2025
enesozturk
reviewed
Jan 14, 2025
| this.setPreferredAccountType(preferredAccountType, namespace) | ||
|
|
||
| const userAccounts = user.accounts?.map(account => | ||
| CoreHelperUtil.createAccount( | ||
| namespace, | ||
| account.address, | ||
| namespace === ConstantsUtil.CHAIN.EVM ? account.type : 'eoa' | ||
| account.type || OptionsController.state.defaultAccountTypes[namespace] |
There was a problem hiding this comment.
Why not using preferredAccountType variable here?
Suggested change
| account.type || OptionsController.state.defaultAccountTypes[namespace] | |
| account.type || preferredAccountType |
There was a problem hiding this comment.
That's this way because here it is mapping the accounts from user, which seems to may be different from user.preferredAccountType
tomiir
approved these changes
Jan 14, 2025
enesozturk
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
defaultAccountTypesoption for AppKit initialization.Type of change
Associated Issues
For Linear issues: Closes APKT-1870
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist