Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:fix copy address instead of ENS name #3565

Merged
merged 27 commits into from
Jan 2, 2025
Merged

:fix copy address instead of ENS name #3565

merged 27 commits into from
Jan 2, 2025

Conversation

svenvoskamp
Copy link
Contributor

Description

Fix an issue where users with an ENS couldn't copy their address. Also added UI tests for w3m-profile-view.ts

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 2:26pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 2:26pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-vue-solana ⬜️ Ignored (Inspect) Dec 31, 2024 2:26pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Dec 31, 2024 2:26pm
vue-wagmi-example ⬜️ Ignored (Inspect) Dec 31, 2024 2:26pm

Copy link

changeset-bot bot commented Dec 31, 2024

🦋 Changeset detected

Latest commit: 09a6fd6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit-scaffold-ui Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 31, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 63.75% 17961 / 28174
🔵 Statements 63.75% 17961 / 28174
🔵 Functions 53.95% 1535 / 2845
🔵 Branches 77.97% 2879 / 3692
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/scaffold-ui/src/views/w3m-profile-view/index.ts 89.89% 87.5% 77.77% 89.89% 43, 51, 56, 62-63, 117, 129, 157, 167-168
Generated in workflow #8558 for commit 09a6fd6 by the Vitest Coverage Report Action

@svenvoskamp svenvoskamp merged commit 93cee5c into main Jan 2, 2025
19 checks passed
@svenvoskamp svenvoskamp deleted the fix/copy-address branch January 2, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants