Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: nuxt wagmi example #3430

Merged
merged 14 commits into from
Jan 9, 2025
Merged

chore: nuxt wagmi example #3430

merged 14 commits into from
Jan 9, 2025

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Dec 11, 2024

Description

Adds Nuxt Wagmi example

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: 6940c39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 9:51am
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 9:51am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 9:51am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-vue-solana ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 9:51am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 9:51am
vue-wagmi-example ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 9:51am

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 64.68% 18357 / 28381
🔵 Statements 64.68% 18357 / 28381
🔵 Functions 55.18% 1581 / 2865
🔵 Branches 78.5% 3024 / 3852
File CoverageNo changed files found.
Generated in workflow #8698 for commit 6940c39 by the Vitest Coverage Report Action

@tomiir
Copy link
Collaborator

tomiir commented Dec 23, 2024

@enesozturk @rtomas wyt about moving this to appkit-web-examples and start centralizing examples there with purpose of adding E2E there later down the line?

@enesozturk
Copy link
Contributor Author

enesozturk commented Dec 23, 2024

@enesozturk @rtomas wyt about moving this to appkit-web-examples and start centralizing examples there with purpose of adding E2E there later down the line?

Taking a wide run for this would be super nice (also as discussed in Slack about it);

  • Add more variety for all frameworks to https://github.com/reown-com/appkit-web-examples, like Svelte, Angular
  • Have common UI solution which can be used in all examples? to have same UI and functionalities in all examples
  • All examples should be easy to run & develop with AppKit repo

Totally agree with centralizing them as we have separate examples in different places.

@enesozturk enesozturk requested a review from tomiir January 8, 2025 16:47
@enesozturk enesozturk merged commit 965086d into main Jan 9, 2025
19 checks passed
@enesozturk enesozturk deleted the chore/nuxt-wagmi-example branch January 9, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants