Fix wrong OID format type in repack_trigger #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
table OID should be unsigned four-byte integer, therefore formatting with %d is wrong. %u should be used as in other places. It's surprising that we haven't received such error messages before. But such a query is definitely wrong "INSERT INTO repack.log_-907750756(pk, row) "
za-arthur
approved these changes
Dec 15, 2023
|
Thank you for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table OID should be unsigned four-byte integer, therefore formatting with %d is wrong. %u should be used as in other places.
It's surprising that we haven't received such error messages before. But such a query is definitely wrong:
I have no idea how to add a test with large OID.