Address #387, "Current Product Module" issues with swift/Xcode-11.3 #388
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That the custom base class is not sanitised (leading '.' from default/implicit module creeps in) The filename has the same symptom except '.' gets replaced with '_', but in the case of the useless leading prefix, it ends up being '__' for machine file.
|
@rentzsch just checking it looks like this is still valid as there haven't been any new commits since then. I'd love your thoughts |
|
Hey Mitchell, thanks for the poke. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That the custom base class is not sanitised (leading '.' from default/implicit module creeps in)
The filename has the same symptom except '.' gets replaced with '_', but in the case of the useless leading prefix, it ends up being '__' for machine file.