Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 3 changes #349

Merged
merged 3 commits into from
Oct 3, 2016
Merged

Swift 3 changes #349

merged 3 commits into from
Oct 3, 2016

Conversation

hardikdevios
Copy link
Contributor

@hardikdevios hardikdevios commented Sep 29, 2016

Swift 3 - NSDate is now Date 3 mogenrator.m
Swift 3 - In One to Many Relationship methods making first argument optional machine.swift.motemplate

hardikdevios and others added 2 commits September 29, 2016 11:03
Swift 3 Making Optional first parameters in one to many relation
Copy link
Owner

@rentzsch rentzsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but looks like the Swift tests are failing.

@hardikdevios
Copy link
Contributor Author

Yes the reason is in your rake file you have Update the SDK and XCode but swift code is old in OSX. Do you want me to fix that issue as well Bro?

@rentzsch
Copy link
Owner

Ah, is that the issue? Yes please, you're in best position to figure out what's wrong and how to fix it.

@hardikdevios
Copy link
Contributor Author

hardikdevios commented Oct 3, 2016

  • rake clean
  • rake

I Think you are good to go with final Swift 3. Let me know for any other request Happy to help. 👍

Major Change for Swift 3

AnyObject to Any for SE-0116

@rentzsch rentzsch merged commit bbefc89 into rentzsch:master Oct 3, 2016
@rentzsch rentzsch mentioned this pull request Oct 3, 2016
@hardikdevios
Copy link
Contributor Author

Cheers

@heumn
Copy link

heumn commented Oct 8, 2016

Hey, I am just dropping by to say THANKS :)

congratulations-agree-136dgbul9Tk8Rq

@hardikdevios hardikdevios changed the title Swift 3 minor changes Swift 3 changes Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants