Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of modernizing mogenerator for a 2.0 (or whatever we call it), I’ve removed the —v2 argument and now we generate Objective-C using ARC, Objective-C literals, and modules out of the box.
There’s still some stuff I don’t like about our Objective-C code I’d like to fix. Namely, the structs for attribute names need to be marked
__unsafe_unretained
because ARC doesn’t support objects in a struct. I wasn’t sure of a better way to handle that without adding a bunch of extra code.I’d also like to add nullability attributes to Objective-C where appropriate, but we can save that for another day (Patches Welcomed!)
This is obviously a breaking change, and I always opt to go fairly heavy handed on that in favor of moving the project forward. Feedback welcomed.