public entities, optional import of base class module, and various Swift 1.2 fixes #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if Swift custom base class is defined within a module (DDRCoreDataKit) in the example, then the flag --base-class-import DDRCoreDataKit will put import DDRCoreDataKit after import CoreData in the machine generated Swift file
I think this is needed in case a custom subclass is defined within a separate Swift framework/module
Make initializers public.
there may be more, but these are the changes I found when having a fetch request specified in the model
…. Waiting on Swift 1.2 PR's.
minor cleanup of generated code from: public override to: public override
|
Thanks @dave256 |
atomicbird
added a commit
that referenced
this pull request
Apr 29, 2015
public entities, optional import of base class module, and various Swift 1.2 fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@justin, I merged the current feature/swift12 branch with my fixes so this pull request should have just the changes I made and be "mergeable" into the feature/swift12 branch. let me know if you have any issues with it.