Correct generation of fetch requests with repeated variables

[winitzki]

If a CoreData model has a fetch request with a predicate where some variables are repeated, mogenerator will now generate correct Objective-C code.

Example: Suppose a CoreData model has a fetch request with predicate (name==$NAME AND id==$ID ) OR ( surname==$NAME AND id="special"). In this predicate, the variable $NAME is mentioned twice. The current version of mogenerator exports such a fetch request as a function with declaration of this form,

• (NSArray_)fetchGetWhatever:(NSManagedObjectContext_)moc_ NAME:(NSString*)NAME_ ID:(NSString *)ID_ NAME:(NSString *)NAME_;

This does not compile since the parameter "NAME_" is used twice.

My patch corrects this problem and makes sure that variables are used only once.

[rentzsch]

Hi Sergei,

Looks good. Could you remove the // changes by lines before I merge this? The diffs already do a good job of highlighting differences, your name is already on the commit and I promise to give you credit in the release notes :-)

[winitzki]

Hi Jonathan,

yes, I just removed these comments and pushed the change to my repo. This is my first time with github/forking and I was not sure how to make clear where the changes are.

Regards,
Sergei

On Aug 16, 2012, at 11:34 PM, Jonathan 'Wolf' Rentzsch wrote:

Hi Sergei,

Looks good. Could you remove the // changes by lines before I merge this? The diffs already do a good job of highlighting differences, your name is already on the commit and I promise to give you credit in the release notes :-)

—
Reply to this email directly or view it on GitHub.

[rentzsch]

Well then I'm glad I held your hand a little through the process. Welcome to forking :) Pulled.