Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make new 1.24 Mike Ash-style constant structures optional #83

Closed
seanm opened this issue Jan 6, 2012 · 7 comments
Closed

Make new 1.24 Mike Ash-style constant structures optional #83

seanm opened this issue Jan 6, 2012 · 7 comments

Comments

@seanm
Copy link
Contributor

seanm commented Jan 6, 2012

As best as I can gather from machine.h.motemplate, the new "Mike Ash-style constant structures for attributes, relationships and fetched properties" added in 1.24 are not optional.

(Forgive the noise if I've missed an option somewhere.)

I'd like them to be optional because they gunk up Xcode's autocomplete list with things that many users may never use.
@rentzsch
Copy link
Owner

rentzsch commented Jan 6, 2012

I purposely didn't make them optional (see #72) since I didn't see a downside. You've just given me one. Send me a pull request and I'll merge it.

@seanm
Copy link
Contributor Author

seanm commented Jan 6, 2012

OK, I'll give it a try. What UI do you want for the option? A "TemplateVar"?

@rentzsch
Copy link
Owner

rentzsch commented Jan 6, 2012

Yeah, a template var. Let's default to Ash-style on

@bgulanowski
Copy link

They should be off if ARC is enabled--they're not compatible with ARC.

@rentzsch
Copy link
Owner

@bgulanowski I don't think that's right about ARC.

No motion on this issue, so I'm closing it. Will reopen if anything happens.

seanm added a commit to seanm/mogenerator that referenced this issue Jul 22, 2015
@seanm
issue rentzsch#83: add template var to make Mike Ash-style structs op…
6e99d9f 
…tional
@seanm
Copy link
Contributor Author

seanm commented Jul 22, 2015

OK, I gave this a shot... please review carefully, as I don't know the codebase really. :)

seanm added a commit to seanm/mogenerator that referenced this issue Oct 18, 2024
@seanm
issue rentzsch#83: Added option to make Mike Ash-style classes optional
b89f8cd 
No change in behaviour by default.

But now if the command line includes `--template-var include-ash-classes=false` then these classes will not be created.

If you don't use them, this reduces code size a bit (200 KB / 0.12 % in my case) and removes things from Xcode's autocomplete that are just clutter.
@seanm
Copy link
Contributor Author

seanm commented Oct 18, 2024

So looks like these Mike Ash structures got transformed to NSObject subclasses here: #317 for better ARC support.

But the issue of polluting Xcode's autocomplete list for those of us that don't use them remains.

I've reworked my old patch (seanm@6e99d9f#diff-6f2501f0943c18588369ae6ab501bdca726d6486b0b3be8b2909566d12e7d16dR946) with a new one: #401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rentzsch @seanm @bgulanowski