Fixes for analog timer. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use in appropriate places.
- Account for floating point rounding errors in adding up secondsElapsed.
- Account for rounding errors with a timer in fractional seconds.
- If within UPDATES_PER_SECOND/2 of the stopping time, suppress the slide advance.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please pull these fixes, which fix some edge cases with floating point rounding errors due to non-integral timer interval.
I know the math is kind of belabored, probably there will be refactorings; Randy is looking into that.
Nothing like patching up the code 1 hour before the Blitz talks.
Thanks for starting this project!
Kevin