-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(git): add debug #9683
fix(git): add debug #9683
Conversation
return !branches.all.map(localName).includes(branchName); | ||
const isStale = !branches.all.map(localName).includes(branchName); | ||
logger.debug( | ||
{ isStale, branches, currentBranch, currentBranchSha }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will log the full non-stale branch list once per-branch which calls isStale, right?
i.e. if there are 20 branches and 10 are non-stale then we'd get the same list of 10 branches logged 20 times during a run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but sometimes there must be something wrong. i don't now yet what, so i can reduce to only log branches.all
but the branches.branches
value can be interesting too, when the issue occure. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe currentbranchSha
is wrong because of a silent git error happened on an other branch before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More logging never hurt 😉
We might want to drop the branches logging soon if it becomes too verbose |
It's all in debug though, so barely anyone will see it. |
🎉 This PR is included in version 25.3.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Log some debug from
isBranchStale
to find a stale branch bugContext:
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: