refactor(build): Pre-compile files imported from data folder #7896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Dec 7, 2020
viceice
requested changes
Dec 7, 2020
Co-authored-by: Michael Kriese <[email protected]>
…ovate into refactor/data-files-codegen
|
Ha, didn't expect it will help to get rid of dependency I found problematic some time ago |
viceice
previously approved these changes
Dec 7, 2020
yarn.lock
Outdated
Comment on lines
7812
to
7807
| lodash._bindcallback "*" | ||
| lodash._cacheindexof "*" | ||
| lodash._createcache "*" | ||
| lodash._getnative "*" |
There was a problem hiding this comment.
haha, renovate yarn patch strikes again 😛
There was a problem hiding this comment.
I was wrong about find-up
|
🤦♂️ nuget needs find-up |
added 2 commits
December 7, 2020 17:00
viceice
approved these changes
Dec 7, 2020
|
🎉 This PR is included in version 23.97.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
According to microsoft/TypeScript#10939, it would be tricky to just
import example from 'example.txt''.Thus, we're using
data/folder for this.After this PR, we pre-compile files from this folder and import it as JavaScript
Map.Generated file example
Context:
Ref: #7157
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: