feat: Support multiple update types #6888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zharinov
changed the title
zharinov
commented
Jul 30, 2020
zharinov
commented
Jul 30, 2020
| updateConfig, | ||
| updateConfig[updateType] | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Another one potentially dangerous place, though it's working for now (with single values)
viceice
reviewed
Aug 1, 2020
| const sortDiff = | ||
| sortOrder.indexOf(a.updateType) - sortOrder.indexOf(b.updateType); | ||
| sortOrder.indexOf(aUpdateType) - sortOrder.indexOf(bUpdateType); |
There was a problem hiding this comment.
So this now depends on order of assigned update types? We need to think about this sorting
zharinov
force-pushed
the
feat/multiple-update-types
branch
from
30e0cd8 to
1349d8e
Compare
rarkins
requested changes
Aug 4, 2020
added 2 commits
August 4, 2020 14:00
|
|
I'm not certain about this one. Let's park it in Draft for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #6791