Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): lock file maintenance #4313

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 19, 2019

This PR contains the following updates:

Update Change Sourcegraph
lockFileMaintenance All locks refreshed code search for ""

🔧 This Pull Request updates lock files to use the latest dependency versions.


Renovate configuration

📅 Schedule: "before 3am on Monday" (UTC).

🚦 Automerge: Enabled.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot added the ready label Aug 19, 2019
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch from c2eb9f0 to 4f5f8ca Compare August 19, 2019 05:14
@rarkins
Copy link
Collaborator

rarkins commented Aug 19, 2019

 PASS  test/manager/bundler/artifacts.spec.ts

<--- Last few GCs --->

[519:0x35e91f0]    87212 ms: Mark-sweep 1305.4 (1443.6) -> 1291.4 (1442.6) MB, 642.5 / 0.1 ms  (average mu = 0.107, current mu = 0.046) allocation failure scavenge might not succeed
[519:0x35e91f0]    87880 ms: Mark-sweep 1308.3 (1444.6) -> 1293.3 (1441.6) MB, 620.1 / 0.0 ms  (average mu = 0.090, current mu = 0.072) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x1944524dbe1d]
Security context: 0x1eb204a1e6e9 <JSObject>
    1: deepCyclicCopyArray(aka deepCyclicCopyArray) [0x228952d9d239] [/root/project/node_modules/jest-util/build/deepCyclicCopy.js:~80] [pc=0x1944532a4996](this=0x25e381c026f1 <undefined>,array=0x310a4491c269 <JSArray[2]>,options=0x31a321bbcef1 <Object map = 0x26ac6cf282c9>,cycles=0x08da7bc1be61 <JSWeakMap>)
    2: deepCyclicCopyObject(aka deepCyclicCopyObje...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8fa060 node::Abort() [/usr/local/bin/node]
 2: 0x8fa0ac  [/usr/local/bin/node]
 3: 0xaff7ee v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/usr/local/bin/node]
 4: 0xaffa24 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/usr/local/bin/node]
 5: 0xef3f32  [/usr/local/bin/node]
 6: 0xef4038 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [/usr/local/bin/node]
 7: 0xf00112 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/usr/local/bin/node]
 8: 0xf00a44 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/usr/local/bin/node]
 9: 0xf036b1 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [/usr/local/bin/node]
10: 0xeccb34 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [/usr/local/bin/node]
11: 0x116ccbe v8::internal::Runtime_AllocateInNewSpace(int, v8::internal::Object**, v8::internal::Isolate*) [/usr/local/bin/node]
12: 0x1944524dbe1d 
error Command failed with exit code 1.

@rarkins
Copy link
Collaborator

rarkins commented Aug 19, 2019

There are quite a few jest updates in this. Maybe one causes a memory leak. Cc @viceice

@viceice
Copy link
Member

viceice commented Aug 19, 2019

maybe related? jestjs/jest#6399

@viceice
Copy link
Member

viceice commented Aug 19, 2019

We should make a local run with -i --detectLeaks

@rarkins
Copy link
Collaborator

rarkins commented Aug 19, 2019

Unfortunately we get a billion of these:

  ● Test suite failed to run

    EXPERIMENTAL FEATURE!
    Your test suite is leaking memory. Please ensure all references are cleaned.

    There is a number of things that can leak memory:
      - Async operations that have not finished (e.g. fs.readFile).
      - Timers not properly mocked (e.g. setInterval, setTimeout).
      - Keeping references to the global scope.

Note the last one :)

@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch from 4f5f8ca to eade0af Compare August 19, 2019 13:45
@rarkins
Copy link
Collaborator

rarkins commented Aug 19, 2019

CircleCI node v10 has passed every time now that I set --maxWorkers=2. Also it really sped up tests. Trying the same on Azure Pipelines

@viceice
Copy link
Member

viceice commented Aug 19, 2019

Ok, we should remove all global variables anyways

@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 4 times, most recently from 941a0ad to 153f80a Compare August 19, 2019 15:21
@viceice
Copy link
Member

viceice commented Aug 19, 2019

and we should find all leaking promises

@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 5 times, most recently from b98efcc to f0ceb19 Compare August 19, 2019 19:08
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch from f0ceb19 to 4bce194 Compare August 19, 2019 19:09
@renovate renovate bot merged commit aa63499 into master Aug 19, 2019
@renovate renovate bot deleted the renovate/lock-file-maintenance branch August 19, 2019 19:34
@renovate-bot
Copy link
Collaborator

🎉 This PR is included in version 19.30.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants