Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource/dart-version): skip old svn revisions #34059

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

viceice
Copy link
Member

@viceice viceice commented Feb 6, 2025

Changes

The server returns old svn revisions as versions, they need manual mapping to version. We simply skip them instead, because they are very old ( <1.11)

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice added the priority-2-high Bugs impacting wide number of users or very important features label Feb 6, 2025
@viceice viceice enabled auto-merge February 6, 2025 08:50
@viceice viceice added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@viceice viceice added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit ad7ae2a Feb 6, 2025
41 checks passed
@viceice viceice deleted the fix/datasource/dart-version-svn-revisions branch February 6, 2025 09:09
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.162.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource:dart-version priority-2-high Bugs impacting wide number of users or very important features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants