-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config/toml): support jinja templates in toml files #33123
Open
jiaweikho
wants to merge
11
commits into
renovatebot:main
Choose a base branch
from
jiaweikho:feat/toml-template-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+78
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiaweikho
changed the title
feat(config/toml) Support jinja templates in toml files
feat(config/toml) support jinja templates in toml files
Dec 15, 2024
Following the specification in https://jinja.palletsprojects.com/en/stable/templates/#synopsis, there are three types of delimiters: 1. Statements 2. Expressions 3. Comments
jiaweikho
force-pushed
the
feat/toml-template-support
branch
from
December 15, 2024 15:52
fa5430b
to
0099a48
Compare
jiaweikho
changed the title
feat(config/toml) support jinja templates in toml files
feat(config/toml): support jinja templates in toml files
Dec 15, 2024
viceice
reviewed
Dec 15, 2024
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
@viceice I've added tests for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
removeTemplate
option to theparseToml
functionremoveTemplate: true
config topoetry
andpep621
pyproject.toml
parsers.Context
This addresses the feature request raised in #33105 by applying a similar method in the
yaml
parser in #26682.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: