feat: sharedVariableName #33111
Draft
feat: sharedVariableName #33111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs testing on at least one real repo |
rarkins
commented
Dec 14, 2024
| const groupName = result.spec; | ||
| const specName = result.spec; |
There was a problem hiding this comment.
I want to avoid using the string groupName at all in lib/modules/manager
rarkins
commented
Dec 14, 2024
There was a problem hiding this comment.
I'm not familiar with why we needed grouping on Cocoapods
There was a problem hiding this comment.
Looks like it's been there since originally implemented by @zharinov
|
FYI I want to have a similar concept for |
viceice
reviewed
Dec 14, 2024
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
viceice
approved these changes
Dec 14, 2024
| @@ -305,6 +305,7 @@ export interface RenovateConfig | |||
| statusCheckNames?: Record<StatusCheckKey, string | null>; | |||
| env?: UserEnv; | |||
| logLevelRemap?: LogLevelRemap[]; | |||
| sharedVariableName?: string; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replaces
groupNamein manager extract results withsharedVariableNameinstead. I chose to keepgroupNamelater for simplicity and backwards compatibility.Context
We should still group updates if they have shared variables, but separate the concept from manually-configured groupNames.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: