Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(logger): improve readability and modularity #33058

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

refactor(logger): improve readability and modularity #33058

wants to merge 20 commits into from
+339 −127

Conversation

Gabriel-Ladzaretti
Copy link
Collaborator

Changes

Context

This improves modularity and usability in other Renovate wrapper projects.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Gabriel-Ladzaretti

This comment was marked as outdated.

Sign in to view
viceice
viceice reviewed Dec 12, 2024
View reviewed changes
lib/logger/once.spec.ts Outdated Show resolved Hide resolved
lib/logger/index.ts Outdated Show resolved Hide resolved
lib/logger/index.ts Outdated Show resolved Hide resolved
lib/logger/index.ts Outdated Show resolved Hide resolved
@Gabriel-Ladzaretti Gabriel-Ladzaretti marked this pull request as draft December 15, 2024 13:44
@Gabriel-Ladzaretti Gabriel-Ladzaretti marked this pull request as ready for review December 15, 2024 17:35
@Gabriel-Ladzaretti
Copy link
Collaborator Author

Gabriel-Ladzaretti commented Dec 15, 2024 •
edited
Loading

there was ai had a bug in with the logFactory and the way the logging attributes were handled.
it has been fixed, and I also improved some of the unit tests that didnt catch it initially.

can we please review it again? thanks a lot.

cc @viceice @secustor

@viceice
Copy link
Member

viceice commented Dec 15, 2024

please split the fix from this refactoring

@Gabriel-Ladzaretti
Copy link
Collaborator Author

Gabriel-Ladzaretti commented Dec 15, 2024 •
edited
Loading

please split the fix from this refactoring

but thats impossible, its a bug i introduced in this pr 😅.
maybe i should have improved my phrasing in the commend i made.

viceice
viceice reviewed Dec 16, 2024
View reviewed changes
lib/logger/index.spec.ts Outdated Show resolved Hide resolved
lib/logger/renovate-logger.ts Outdated Show resolved Hide resolved
lib/logger/renovate-logger.ts Outdated Show resolved Hide resolved
lib/logger/renovate-logger.ts Outdated Show resolved Hide resolved
lib/logger/renovate-logger.ts Outdated Show resolved Hide resolved
lib/logger/index.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed Dec 16, 2024
View reviewed changes
lib/logger/index.ts Outdated Show resolved Hide resolved
lib/logger/renovate-logger.ts Outdated Show resolved Hide resolved
@Gabriel-Ladzaretti @viceice
review changes
4b53eda 
Co-authored-by: Michael Kriese <[email protected]>
viceice
viceice reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's improve further in next pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice approved these changes

@zharinov zharinov Awaiting requested review from zharinov

@secustor secustor Awaiting requested review from secustor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gabriel-Ladzaretti @viceice @secustor