Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(packages): atlaskit source url #32690

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(packages): atlaskit source url #32690

wants to merge 2 commits into from

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Nov 23, 2024 •
edited
Loading

Changes

add atlaskit source url to packages preset

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice requested changes Nov 23, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update PR description to include reasons why this needs to be done.

this fundamentally changes the rule behavior

@setchy setchy marked this pull request as draft November 23, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice requested changes

@rarkins rarkins Awaiting requested review from rarkins

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @viceice