Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maven): Exclude pom checks for JetBrains registry #32375

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Nov 6, 2024

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov changed the title fix(maven): Exclude pom checks for jetbrains registry fix(maven): Exclude pom checks for JetBrains registry Nov 6, 2024
@rarkins
Copy link
Collaborator

rarkins commented Nov 6, 2024

@Shegox @remal do you think this matches with the problem you observed?

@rarkins
Copy link
Collaborator

rarkins commented Nov 6, 2024

The problem is incorrectly described if so, because this solution is unrelated to extractVersion

@zharinov
Copy link
Collaborator Author

zharinov commented Nov 6, 2024

@Shegox
Copy link
Contributor

Shegox commented Nov 6, 2024

I have been running against a private maven repository on Artifactory and consuming a private package from there. So this wouldn't resolve my specific problem.

Looking a bit more at the initial issue description it might be possible however that they are two different problems.

I will write tomorrow morning a test case for my exact scenario, maybe this helps to narrow it down :)

@zharinov zharinov closed this Nov 6, 2024
@remal
Copy link

remal commented Nov 8, 2024

@rarkins I think the issue is that Renovate:

  1. Retrives a new version
  2. Applies extractVersion
  3. Checks that the extracted version exists

I extract version not because it's wrongly retrieved, but because I need it in another format for my build script.

I think what could work if the step 3 was before step 2. But it could break something else. So, the more I think about it, the more I believe that step 3 (checking that the version actually exists) should be configurable. What do you think?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extractVersion with postProcessRelease (maven) causes rejected release
4 participants