Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundler): add source variables support #32337

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

Djiit
Copy link
Contributor

@Djiit Djiit commented Nov 5, 2024

Changes

Added variables support in Gemfile.

Context

Fixes #23931

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Djiit Djiit force-pushed the feat-bundler-variable-support branch 8 times, most recently from 7bc6760 to f239c63 Compare November 5, 2024 12:31
@Djiit Djiit marked this pull request as ready for review November 5, 2024 12:33
@Djiit Djiit force-pushed the feat-bundler-variable-support branch from f239c63 to 8dfc02d Compare November 5, 2024 12:43
@rarkins rarkins requested a review from zharinov November 5, 2024 13:16
lib/modules/manager/bundler/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/bundler/extract.spec.ts Outdated Show resolved Hide resolved
@zharinov zharinov self-requested a review November 12, 2024 17:32
@Djiit
Copy link
Contributor Author

Djiit commented Nov 15, 2024

Hey team, do you need anything from me to get this merged? Thank you 🙏 cc @rarkins

@rarkins rarkins added this pull request to the merge queue Nov 15, 2024
Merged via the queue into renovatebot:main with commit a1c5150 Nov 15, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Djiit Djiit deleted the feat-bundler-variable-support branch November 18, 2024 18:59
ssams pushed a commit to ssams/renovate that referenced this pull request Dec 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Gemfile source variables
5 participants