fix(gomod): GOPROXY with slash doesnt work

[PhilipAbed]

Changes

trimm slash while parsing GOPROXY

Context

some customer run failed with this error
DEBUG: Goproxy error: trying next URL provided with GOPROXY

the URL in the error had 2 slashes // after go.
"url": "https://{XYZ.ARTIFACTORY}/go//x/y/z/v3/@v/list",

when i checked code for this i found the slash is hardcoded into this

renovate/lib/modules/datasource/go/releases-goproxy.ts

Line 132 in 4bea95b

const url = `${baseUrl}/${this.encodeCase(packageName)}/@v/list`;

the simple solution is to trim the slash from GOPROXY in the parser before it, as it is not necessary.

let me know if you think otherwise.

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[rarkins]

Why is a trailing slash a problem if parsed with it? It's valid in URLs obviously

[rarkins]

I think that this approach to fixing it is not robust. It's done in a separate file to where the problem occurs. We should either use a better way of joining URLs, or do the trailing slash trimming at the point of static joining

[PhilipAbed]

so you are saying the issue is with
const url = ${baseUrl}/${this.encodeCase(packageName)}/@v/list;
its kind of hardcoded, we should use some URL joiner here

[viceice]

so you are saying the issue is with
const url = ${baseUrl}/${this.encodeCase(packageName)}/@v/list;
its kind of hardcoded, we should use some URL joiner here

yes, that's better

[PhilipAbed]

im afraid to use url joiner since the url.parser and joiner are broken if set without protocol.

discussion: #30295

i haven't seen any docs indicating that the URLS set in GOPROXY can be without a protocol like https:// .. etc, so i think its ok

[renovate-release]

🎉 This PR is included in version 39.0.1 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)
• 39.0.1

Your semantic-release bot 📦🚀