Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix timestamps for internalChecksFilter checks #32204

Merged
merged 3 commits into from
Oct 29, 2024
Merged

fix: Fix timestamps for internalChecksFilter checks #32204

merged 3 commits into from
Oct 29, 2024

Conversation

zharinov
Copy link
Collaborator

Changes

  • Use releaseTimestamp from the post-processed release item rather than from config object

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested a review from rarkins October 29, 2024 19:08
@zharinov zharinov requested a review from viceice October 29, 2024 19:15
@rarkins rarkins added this pull request to the merge queue Oct 29, 2024
Merged via the queue into renovatebot:main with commit d12b94c Oct 29, 2024
39 checks passed
@rarkins rarkins deleted the fix/internal-filter-checks-release-minimum-age branch October 29, 2024 20:24
@gillyobeast
Copy link

this explains a lot! thanks for fixing :D

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zharinov @gillyobeast @viceice @rarkins