fix(circleci): parsing of inline orb definitions #31843
Merged
+116
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steved
commented
Oct 7, 2024
viceice
reviewed
Oct 8, 2024
steved
force-pushed
the
steved/circleci-orb-orbs
branch
from
d8f2826 to
d4a3c40
Compare
rarkins
previously approved these changes
Oct 22, 2024
|
No need to merge from main if no changes have been made |
viceice
requested changes
Oct 24, 2024
steved
force-pushed
the
steved/circleci-orb-orbs
branch
from
62e9fb1 to
5936baf
Compare
secustor
reviewed
Oct 24, 2024
secustor
previously approved these changes
Oct 25, 2024
rarkins
previously approved these changes
Oct 26, 2024
|
@viceice mind re-reviewing? thanks! |
viceice
reviewed
Nov 5, 2024
auto-merge was automatically disabled
November 5, 2024 20:42
Head branch was pushed to by a user without write access
viceice
reviewed
Nov 5, 2024
rarkins
previously approved these changes
Nov 21, 2024
steved
force-pushed
the
steved/circleci-orb-orbs
branch
from
84a457e to
9959872
Compare
steved
force-pushed
the
steved/circleci-orb-orbs
branch
from
9959872 to
d92a865
Compare
viceice
approved these changes
Dec 14, 2024
|
🎉 This PR is included in version 39.69.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#30142 changed how CircleCI config parsing worked, but didn't take into account inline orb definitions.
Context
The
config5.ymlfixture is a valid CircleCI config:However, we lost the ability to parse out inline orb definitions which can include orb references and images.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: