Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbt-package): Don't reject Maven packages #31842

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Oct 7, 2024

Changes

The packages with unconventional naming scheme get rejected as they don't comply with Maven conventions. In this case, we need to leave release as-is, for now without trying to obtain releaseTimestamp.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested review from viceice and rarkins October 7, 2024 20:49
@rarkins rarkins added this pull request to the merge queue Oct 8, 2024
Merged via the queue into renovatebot:main with commit e86c553 Oct 8, 2024
38 checks passed
@rarkins rarkins deleted the fix/sbt-package-reject-release branch October 8, 2024 07:16
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.111.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

zemnmez-renovate-bot added a commit to zemn-me/monorepo that referenced this pull request Oct 8, 2024
##### [`v38.111.1](https://github.com/renovatebot/renovate/releases/tag/38.111.1)

##### Bug Fixes

-   **sbt-package:** Don't reject Maven packages ([#31842](renovatebot/renovate#31842)) ([e86c553](renovatebot/renovate@e86c553))

##### Code Refactoring

-   **sbt:** Decouple `sbt-package` and `sbt-plugin` datasources ([#31835](renovatebot/renovate#31835)) ([c5dfee3](renovatebot/renovate@c5dfee3))
github-merge-queue bot pushed a commit to zemn-me/monorepo that referenced this pull request Oct 8, 2024
##### [`v38.111.1](https://github.com/renovatebot/renovate/releases/tag/38.111.1)

##### Bug Fixes

-   **sbt-package:** Don't reject Maven packages ([#31842](renovatebot/renovate#31842)) ([e86c553](renovatebot/renovate@e86c553))

##### Code Refactoring

-   **sbt:** Decouple `sbt-package` and `sbt-plugin` datasources ([#31835](renovatebot/renovate#31835)) ([c5dfee3](renovatebot/renovate@c5dfee3))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants