Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packageRules): matchJsonata #31826

Merged
merged 28 commits into from
Oct 8, 2024
Merged

feat(packageRules): matchJsonata #31826

merged 28 commits into from
Oct 8, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Oct 7, 2024

Changes

Add matchJsonata configuration option to packageRules.

Context

Closes #31820

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Fixes #31820

Add `matchJsonata` configuration option to `packageRules`.

* Add new option `matchJsonata` of type string with parent `packageRules` in `lib/config/options/index.ts`.
* Create `JsonataMatcher` class in `lib/util/package-rules/jsonata.ts` extending `Matcher` and implement `matches` method using JSONata.
* Import `JsonataMatcher` in `lib/util/package-rules/matchers.ts` and add it to the `matchers` array.
* Add tests for `JsonataMatcher` class in `lib/util/package-rules/jsonata.spec.ts`.
* Update types to include `matchJsonata` under `packageRules` in `lib/config/types.ts`.
@rarkins rarkins changed the base branch from main to refactor/async-matcher October 7, 2024 13:26
Base automatically changed from refactor/async-matcher to main October 7, 2024 14:15
@rarkins rarkins requested review from viceice and secustor October 7, 2024 14:43
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the unrelated changes

lib/util/package-rules/base.ts Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Show resolved Hide resolved
lib/config/types.ts Outdated Show resolved Hide resolved
@rarkins rarkins changed the base branch from main to feat/jsonata-caching October 7, 2024 18:56
viceice
viceice previously approved these changes Oct 8, 2024
Base automatically changed from feat/jsonata-caching to main October 8, 2024 09:18
@rarkins rarkins dismissed viceice’s stale review October 8, 2024 09:18

The base branch was changed.

lib/config/validation.ts Outdated Show resolved Hide resolved
@rarkins rarkins requested review from secustor and viceice October 8, 2024 11:25
@rarkins rarkins added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 32ecb4c Oct 8, 2024
36 checks passed
@rarkins rarkins deleted the feat/31820-match-jsonata branch October 8, 2024 11:41
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.114.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

zemnmez-renovate-bot added a commit to zemn-me/monorepo that referenced this pull request Oct 8, 2024
github-merge-queue bot pushed a commit to zemn-me/monorepo that referenced this pull request Oct 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packageRules.matchJsonata
5 participants