Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/pip_setup): set currentVersion field for exact dependency versions #31021

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

Shegox
Copy link
Contributor

@Shegox Shegox commented Aug 26, 2024

Changes

Adds currentVersion values to extracted dependencies that are specified with an exact version requirement. This change enables vulnerability fix PRs for dependencies located in a pip_setup file.

Before this PR, Renovate would log something like this:

DEBUG: Skipping vulnerability lookup for package requests due to unsupported version ==2.31.0 (repository=xxxxx)

After this PR it correctly looks up the vulnerabilities for this dependency and reports them:

DEBUG: Vulnerability GHSA-9wx4-h78v-vm56 affects requests 2.31.0 (repository=xxxxx)

Context

Similar to #26769, just for pip_setup
Related initial discussion: #20542 (comment)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository (only as a dry run)

@rarkins rarkins added this pull request to the merge queue Aug 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 26, 2024
@viceice viceice added this pull request to the merge queue Aug 26, 2024
Merged via the queue into renovatebot:main with commit 6c7316c Aug 26, 2024
38 checks passed
@Shegox Shegox deleted the pip-setup-current-version branch August 26, 2024 09:19
@s00hyun
Copy link

s00hyun commented Aug 26, 2024

Thanks a lot for working on this, @Shegox 👍

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.54.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants