Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager): add glasskube manager #30774

Merged

Conversation

kosmoz
Copy link
Contributor

@kosmoz kosmoz commented Aug 14, 2024

Changes

This PR adds a new manager that allows extraction of version data and registryUrl for Glasskube resources.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@kosmoz
Copy link
Contributor Author

kosmoz commented Aug 14, 2024

I think this PR completes #29322. Should we update the documentation in the same PR?

@viceice viceice self-requested a review August 14, 2024 15:55
lib/modules/manager/glasskube/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/glasskube/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/glasskube/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/glasskube/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/glasskube/extract.ts Show resolved Hide resolved
lib/modules/manager/glasskube/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/glasskube/schema.ts Outdated Show resolved Hide resolved
@kosmoz kosmoz force-pushed the feat/29322-glasskube-packages-manager branch from 7713716 to aa5bdfc Compare August 16, 2024 09:04
@kosmoz kosmoz requested review from viceice and secustor August 16, 2024 09:56
lib/modules/manager/glasskube/extract.spec.ts Show resolved Hide resolved
lib/modules/manager/glasskube/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/glasskube/extract.ts Outdated Show resolved Hide resolved
@kosmoz kosmoz requested a review from viceice August 19, 2024 18:25
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs eslint fix

@kosmoz
Copy link
Contributor Author

kosmoz commented Aug 19, 2024

needs eslint fix

sorry, this was caused by an upstream change so I didn't catch it by linting locally. should be fixed now

@kosmoz kosmoz requested a review from viceice August 19, 2024 22:10
@kosmoz kosmoz requested a review from secustor August 20, 2024 15:22
@secustor secustor added this pull request to the merge queue Aug 20, 2024
Merged via the queue into renovatebot:main with commit 0d20f17 Aug 20, 2024
38 checks passed
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.45.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glasskube Support
4 participants