fix(managers/maven): change order of extracted registryUrls #26828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secustor
reviewed
Jan 23, 2024
lib/modules/manager/maven/__fixtures__/settings.updated.schema.xml
Outdated
Show resolved
Hide resolved
secustor
changed the title
Co-authored-by: Sebastian Poxhofer <[email protected]>
secustor
reviewed
Jan 27, 2024
viceice
reviewed
Jan 29, 2024
secustor
reviewed
Jan 30, 2024
secustor
previously approved these changes
Feb 3, 2024
Co-authored-by: Johannes Feichtner <[email protected]>
Churro
approved these changes
Feb 5, 2024
viceice
reviewed
Feb 5, 2024
Co-authored-by: Michael Kriese <[email protected]>
viceice
previously approved these changes
Feb 5, 2024
viceice
reviewed
Feb 6, 2024
viceice
approved these changes
Feb 6, 2024
|
🎉 This PR is included in version 37.181.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
not7cd
pushed a commit
to uni-intelligence/renovate
that referenced
this pull request
Feb 13, 2024
…bot#26828) Co-authored-by: Sebastian Poxhofer <[email protected]> Co-authored-by: Johannes Feichtner <[email protected]> Co-authored-by: Michael Kriese <[email protected]>
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds the repository urls for maven in the correct order parsed from
Maven settings files were restricted to ones with schema 1.0.0
Added a check that the settings file is of a supported namespace version as listed here.
Added a test fixture for the settings file following maven example here
Context
Maven central was the first repository in the list of repositories. This was causing dependencies to download from maven central before looking up the repositories specified in the settings.xml or pom.xml.
Settings files that were of a namespace version 1.1.0 or 1.2.0 were skipped over for parsing.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: