Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(git): move git autentification via environment variables to git auth #22821

Merged
merged 7 commits into from
Jun 20, 2023
Merged

feat(git): move git autentification via environment variables to git auth #22821

merged 7 commits into from
Jun 20, 2023

Conversation

Shegox
Copy link
Contributor

@Shegox Shegox commented Jun 16, 2023

Changes

This PR moves the getGitEnvironmentVariables() function from the go manager to the git utils. Allowing it to be easier reused.
As part of the move I added the parameter additionalHostTypes: string[] = [] to allow for dynamically adding further hostTypes (like go for golang hosts).

Context

This PR is a sub-part of #22061

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Shegox Shegox marked this pull request as draft June 16, 2023 10:26
@Shegox Shegox marked this pull request as ready for review June 16, 2023 10:41
viceice
viceice reviewed Jun 16, 2023
View reviewed changes
lib/util/git/auth.ts Outdated Show resolved Hide resolved
lib/util/git/auth.ts Outdated Show resolved Hide resolved
lib/util/git/auth.ts Outdated Show resolved Hide resolved
@Shegox Shegox requested a review from viceice June 19, 2023 05:56
viceice
viceice reviewed Jun 19, 2023
View reviewed changes
lib/util/git/auth.ts Outdated Show resolved Hide resolved
lib/util/git/auth.ts Outdated Show resolved Hide resolved
lib/util/git/auth.ts Outdated Show resolved Hide resolved
@Shegox Shegox requested a review from viceice June 20, 2023 19:00
@viceice viceice changed the title refactor(git): move git autentification via environment variables to git auth feat(git): move git autentification via environment variables to git auth Jun 20, 2023
@viceice viceice added this pull request to the merge queue Jun 20, 2023
Merged via the queue into renovatebot:main with commit 6c6984b Jun 20, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.136.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mugioka mugioka mentioned this pull request Jun 21, 2023
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shegox @renovate-release @viceice