-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update bazel documentation and enable bazel-module
manager
#22803
feat: update bazel documentation and enable bazel-module
manager
#22803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs lint fix
@viceice Thanks. It took me a minute to find the |
Seems like we have sort of flip-flop issue with codecov status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of fixes:
- Reduce capitalization in headings
- Use lists
- Rely on the Markdown renderer (or the site build process) to number ordered lists correctly like
1. 2. 3. 4. ....
- Use simple words and phrases
- Remove duplicate words from list items by creating a platform sentence
Co-authored-by: HonkingGoose <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second round of review. 🙂
Co-authored-by: HonkingGoose <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for @HonkingGoose approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last round. 😉
Co-authored-by: HonkingGoose <[email protected]>
@HonkingGoose I made another pass through the document to ensure we use the same voice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks way better after your voice passes. 🥳 There are still some small things to fix though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge after fixing this thing. 😉
🎉 This PR is included in version 35.123.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
bazel-module
manager.Context
Closes #13658.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: