-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: categories #16534
feat!: categories #16534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your thoughts on whether to remove languages in favour of categories?
I think we should remove it as it basically does the same, but is more flexible. If we want to group tags together we could replace tags with labels ( key/value pairs) and allow matches to them. e.g: use-case: deactivate all activity of Renovate except renovating actual source code {
"packageRules": [
{
"matchCategories": ["language:!/.+/"],
"enabled": "false"
}
]
} That way we can prevent name collisions and give the user more match options. From a migration standpoint the steps would be as following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packageRules using matchCategories can only be applied after extraction? e.g. you cannot use categories to change how the extraction config itself looks?
No, I haven't been aware of this. So this is also the case currently for |
Thoughts on removing |
I think we should implement in parallel at first and deprecate From a technical standpoint there is no reason which would prevent this, but we have changes which does not map one to one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the Markdown docs.
I'll let the maintainers review the code. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any preview of how the autogenerated docs will look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readded comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've read the changed docs, but I don't know if the changes are good or bad.
I think this is the coverage analysis for this PR: https://app.codecov.io/gh/renovatebot/renovate/pull/16534 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
# Conflicts: # docs/usage/configuration-options.md # lib/config/migrations/custom/package-rules-migration.ts # lib/config/presets/internal/config.ts # lib/config/types.ts # lib/util/package-rules/matchers.ts
Co-authored-by: Rhys Arkins <[email protected]> Co-authored-by: Michael Kriese <[email protected]> Co-authored-by: HonkingGoose <[email protected]>
Closes #13953 Co-authored-by: Rhys Arkins <[email protected]> Co-authored-by: Michael Kriese <[email protected]> Co-authored-by: HonkingGoose <[email protected]> BREAKING CHANGE: languages are now called categories instead
Closes #13953 Co-authored-by: Rhys Arkins <[email protected]> Co-authored-by: Michael Kriese <[email protected]> Co-authored-by: HonkingGoose <[email protected]> BREAKING CHANGE: languages are now called categories instead
Closes #13953 Co-authored-by: Rhys Arkins <[email protected]> Co-authored-by: Michael Kriese <[email protected]> Co-authored-by: HonkingGoose <[email protected]> BREAKING CHANGE: languages are now called categories instead
Changes
This PR adds categories to managers and implements a matcher for package rules.
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
https://github.com/secustor/renovate_autodiscoverfilter