-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: suggest to let Renovate bypass mandatory Pull Request reviews #16370
Conversation
You're totally right! 😉 I created an issue to figure out how to describe the branch protection exception for Renovate in our docs: The problem is that we should probably change more than just add a single line somewhere in the docs. And also, if we tell our users to add Renovate bot as an exception, it should work for |
I searched if there was an issue already open for this, but missed that one. 😅 In my test, a PR merge worked. Let me further explore this next week and better document it. |
And testing using So overall it seems to work for all my tested cases: branch and PR and even works, if "Require review from Code Owners" is enabled: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small style change.
Co-authored-by: HonkingGoose <[email protected]>
🎉 This PR is included in version 32.103.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
This PR recommends that users should add Renovate to the list of users, which are allowed to bypass mandatory Pull Request instead of installing the auto-approve App.
This has the advantage that no additional App is required. In the long term, renovate-approve could be deprecated in favor of this approach overall.
Context
GitHub added this new feature in November 2021 and I couldn't find it yet in the Renovate docs.
Fixes #15659
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
Merging without approval: tobias-something-something/automerge-test#3
although required PRs are configured