Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): print hostRules when printConfig=true #15699

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

Shegox
Copy link
Contributor

@Shegox Shegox commented May 23, 2022

Changes

This PR enables Renovate to output the resolved hostRules in addition to the resolved config.
In addition it moves the printConfig option to repository level configuration, as it doesn't need to be in the self-hosted config file.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

As sanitization of secrets is critical I manually verified that following things get sanitized:

  • usage of secrets
  • tokens in repository config
  • tokens and username/password in presets
  • tokens in self-hosted configuration
  • encrypted tokens in repository config

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins changed the title feat(config): print hostRules when printConfig=true and document it as repository config feat(config): print hostRules when printConfig=true Jun 22, 2022
@rarkins rarkins enabled auto-merge (squash) June 22, 2022 09:54
@rarkins rarkins requested a review from viceice June 22, 2022 09:54
@rarkins rarkins merged commit 3d96c7c into renovatebot:main Jun 23, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.95.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

printConfig doesn't include hostRules
4 participants