fix: populate isLockFileMaintenance #14005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lock file maintenance was broken as various managers rely on the `isLockFileMaintenance` update flag to be set. This was not the case as its config is generated afterwards (without the is* auto-propagation).
viceice
reviewed
Feb 4, 2022
rarkins
approved these changes
Feb 5, 2022
|
🎉 This PR is included in version 31.66.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Lock file maintenance was broken as various managers rely on the
isLockFileMaintenanceupdate flag to be set. This was not thecase as its config is generated afterwards (without the is*
auto-propagation).
Context:
Fixes #9728
It restores the lock file maintenance feature for the
pip-compilemanager (it didn't fail but wouldn't report updates). Verified on a real repository. Based on a code search I suspect that at least the managerbundler,composer,jsonnet-bundler,pipenvare affected, too.It would allow reverting #9695, and maybe refactoring other managers to use
isLockFileMaintenanceinstead ofconfig.updateType === 'lockFileMaintenance'. I can include that in this PR if wanted.Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
pip-compile)